bug: pr_files_diff returns same diff for all files #25

New Issue

mathias · 2026-05-15T15:30:55Z

mathias commented

2026-05-15 15:30:55 +00:00

Bug

pr_files_diff returns the same diff content for every file in the response. Each file entry shows identical diff text instead of its own diff.

Observed behaviour

When calling pr_files_diff on PR #21, all 13 files in the response contained the same diff block (the content of repo_update_test.go) regardless of which file path was listed.

Expected behaviour

Each file entry should contain the diff for that specific file.

Likely cause

A loop or variable reuse bug in internal/tools/pr_files_diff.go — probably the diff string is assigned once and reused across iterations instead of being read per file.

Steps to reproduce

Call pr_files_diff on any PR with multiple files and compare the diff content across entries.

Impact

Makes the tool unreliable for code review workflows — cannot use it to inspect individual file changes in a PR.

Fix

Review the loop in internal/tools/pr_files_diff.go that assembles the per-file diff output. Ensure each iteration reads and assigns the correct diff for its own file.

## Bug `pr_files_diff` returns the same diff content for every file in the response. Each file entry shows identical diff text instead of its own diff. ## Observed behaviour When calling `pr_files_diff` on PR #21, all 13 files in the response contained the same diff block (the content of `repo_update_test.go`) regardless of which file path was listed. ## Expected behaviour Each file entry should contain the diff for that specific file. ## Likely cause A loop or variable reuse bug in `internal/tools/pr_files_diff.go` — probably the diff string is assigned once and reused across iterations instead of being read per file. ## Steps to reproduce Call `pr_files_diff` on any PR with multiple files and compare the diff content across entries. ## Impact Makes the tool unreliable for code review workflows — cannot use it to inspect individual file changes in a PR. ## Fix Review the loop in `internal/tools/pr_files_diff.go` that assembles the per-file diff output. Ensure each iteration reads and assigns the correct diff for its own file.

mathias referenced this issue from a commit

2026-05-16 20:43:29 +00:00

docs: update sprint to v0.2 patch — fixes #12, #24, #25

mathias referenced this issue from a commit

2026-05-16 21:03:56 +00:00

fix(pr_files_diff): copy per-file diff bytes to break buffer aliasing

mathias referenced this issue

2026-05-16 21:04:58 +00:00

fix/v02-patch: pr_files_diff, template_name, repo_update #26

mathias referenced this issue from a commit

2026-05-16 22:02:22 +00:00

fix(pr_files_diff): copy per-file diff bytes to break buffer aliasing