8fb44affef
Implements the review skill following the same pattern as retrospective/tdd. Validates project_root and files args, prepends session history when a session_id is provided, and delegates to the executor with Read,Bash tools. Iron-law discipline prompt enforces CRITICAL/WARNING/SUGGESTION output format. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
82 lines
2.0 KiB
Go
82 lines
2.0 KiB
Go
// internal/skills/review/handlers.go
|
|
package review
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"strings"
|
|
|
|
iexec "github.com/mathiasbq/supervisor/internal/exec"
|
|
"github.com/mathiasbq/supervisor/internal/session"
|
|
)
|
|
|
|
type reviewArgs struct {
|
|
ProjectRoot string `json:"project_root"`
|
|
Files []string `json:"files"`
|
|
Context string `json:"context"`
|
|
Model string `json:"model"`
|
|
SessionID string `json:"session_id"`
|
|
}
|
|
|
|
// Handle dispatches the MCP tool call to the appropriate handler.
|
|
func (s *Skill) Handle(ctx context.Context, tool string, args json.RawMessage) (json.RawMessage, error) {
|
|
if tool != "review" {
|
|
return nil, fmt.Errorf("unknown tool: %s", tool)
|
|
}
|
|
var a reviewArgs
|
|
if err := json.Unmarshal(args, &a); err != nil {
|
|
return nil, fmt.Errorf("parse args: %w", err)
|
|
}
|
|
if a.ProjectRoot == "" {
|
|
return nil, fmt.Errorf("project_root is required")
|
|
}
|
|
if len(a.Files) == 0 {
|
|
return nil, fmt.Errorf("files is required")
|
|
}
|
|
|
|
model := a.Model
|
|
if model == "" {
|
|
model = s.cfg.DefaultModel
|
|
}
|
|
|
|
task := fmt.Sprintf(
|
|
"phase: review\nproject_root: %s\nfiles: %s\ncontext: %s\nmodel: %s",
|
|
a.ProjectRoot, strings.Join(a.Files, ", "), a.Context, model,
|
|
)
|
|
task = s.prependHistory(a.SessionID, "review", task)
|
|
|
|
if s.cfg.ExecutorFn == nil {
|
|
return nil, fmt.Errorf("no executor configured")
|
|
}
|
|
result, err := s.cfg.ExecutorFn(ctx, iexec.Request{
|
|
SkillPrompt: s.cfg.SkillPrompt,
|
|
TaskPrompt: task,
|
|
Model: model,
|
|
Tools: "Read,Bash",
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
b, err := json.Marshal(result)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("marshal result: %w", err)
|
|
}
|
|
return b, nil
|
|
}
|
|
|
|
func (s *Skill) prependHistory(sessionID, currentPhase, task string) string {
|
|
if sessionID == "" || s.cfg.SessionsDir == "" {
|
|
return task
|
|
}
|
|
entries, err := session.Read(s.cfg.SessionsDir, sessionID)
|
|
if err != nil || len(entries) == 0 {
|
|
return task
|
|
}
|
|
history := session.FormatHistory(entries, currentPhase)
|
|
if history == "" {
|
|
return task
|
|
}
|
|
return history + "\n---\n\n" + task
|
|
}
|